Skip to content

Add support for deprecated Scala 2.13.x-specific scala runner options #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 16, 2023
Merged

Add support for deprecated Scala 2.13.x-specific scala runner options #1774

merged 7 commits into from
Jan 16, 2023

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Jan 13, 2023 •
edited
Loading

Context: #1721

Added the following deprecated options from the Scala 2 runner, along with appropriate warnings:

  • -howtorun
  • -I
  • -nc

All of them are ignored, with deprecation warnings explaining how Scala CLI does things.

I deliberately skipped over -i, which will stay as an abbrevation for Scala CLI's --interactive mode. It will be documented in #1749.

Did some relevant fixes as well, like adding the missing -verbose alias for -v.
The legacy scala runner options will now also be included in the --full-help (they're all @Hidden, so not in regular -help).

Legacy Scala runner options:
  -save, --save                                  (hidden) Ignored legacy option. Deprecated equivalent of running a subsequent `package` command.
  -nosave, --nosave                              (hidden) Ignored legacy option. Deprecated override canceling the `-nosave` option.
  -howtorun, --how-to-run object|script|jar|repl|guess  (hidden) Ignored legacy option. Deprecated override defining how the runner should treat the input. Use the appropriate sub-command instead.
  -I file                                        (hidden) Ignored legacy option. Deprecated option allowing to preload inputs for the repl or command execution.
  -nc, -nocompdaemon, --no-compilation-daemon    (hidden) Ignored legacy option. Deprecated option allowing to prevent the use of the legacy fsc compilation daemon.

@Gedochao Gedochao added the SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. label Jan 13, 2023
@Gedochao Gedochao force-pushed the legacy-runner-options branch from 38ec6a9 to 0e9b990 Compare January 13, 2023 13:19
@Gedochao Gedochao force-pushed the legacy-runner-options branch 2 times, most recently from c07a5a0 to d2c0227 Compare January 16, 2023 10:29
@Gedochao Gedochao force-pushed the legacy-runner-options branch from d2c0227 to abce9e8 Compare January 16, 2023 10:35
lwronski
lwronski approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao enabled auto-merge January 16, 2023 10:50
@Gedochao Gedochao merged commit 445c0b8 into VirtusLab:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwronski lwronski lwronski approved these changes

@MaciejG604 MaciejG604 Awaiting requested review from MaciejG604

Assignees
No one assigned
Labels
SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gedochao @lwronski